Fix deep-review infra: temp repo missing CMakeLists.txt (local-only)#262
Closed
chhwang wants to merge 2 commits into
Closed
Fix deep-review infra: temp repo missing CMakeLists.txt (local-only)#262chhwang wants to merge 2 commits into
chhwang wants to merge 2 commits into
Conversation
…txt, causing improve/verify failures in P11 (cycles 67,69,71) and P12 (cycle 74). Investigate root cause in the verify step's repo-cloning logic and fix it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 85.48% 85.70% +0.21%
==========================================
Files 129 129
Lines 6457 6457
==========================================
+ Hits 5520 5534 +14
+ Misses 937 923 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chhwang
changed the title
Contributor
Author
|
Empty against microsoft/ark — the deep-review infra fix (setup full-tree copy + CMakeLists.txt pre-flight) was applied to local workflow files, not repo code. Closing without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix deep-review infra: prevent temp repo from omitting CMakeLists.txt
The deep-review
setupagent interpreted Case B ("copy 'before' state")as cherry-picking only changed files, omitting
CMakeLists.txtand otherbuild files from the temp repo. The
verifystep then failed with acryptic CMake error. This caused improve/verify failures in P11 (cycles
67, 69, 71) and P12 (cycle 74).
No ark code changes. Both fixes are to local workflow infrastructure:
setup.mdCase B): Clarified to require full-tree copy(excluding
.git/) for baseline and diff states, matching Case A'sexplicit "copy codebase" instruction.
dev-verify.sh): AddedCMakeLists.txtexistence check before invoking the remote build. Fails fast with a
clear error naming the root cause.
This PR is empty against
microsoft/ark. The fixes were applied directlyto local files. Safe to close without merging.